Skip to content

correctly set springboot port aa #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crosmuller merged 3 commits into from
Jan 8, 2026
Merged

correctly set springboot port aa #594

crosmuller merged 3 commits into from
Jan 8, 2026
+1 −1

Conversation

@crosmuller
Copy link
Contributor

@crosmuller crosmuller commented Dec 22, 2025

Comment is different from real value

@baszoetekouw
Copy link
Member

baszoetekouw commented Jan 5, 2026

Do we really need to make this configurable?
Afaik this needs to be consistent in the container build only: the Dockerfile and java need to agree, both of which are not handled in Ansible. The correct port is then propagated via Traefik-magick.

@crosmuller
Copy link
Contributor Author

crosmuller commented Jan 5, 2026

@baszoetekouw maybe not but the comment and value should be the same

@crosmuller
Copy link
Contributor Author

crosmuller commented Jan 8, 2026

@baszoetekouw ok zo?

@crosmuller crosmuller merged commit 524cc5b into main Jan 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baszoetekouw baszoetekouw baszoetekouw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crosmuller @baszoetekouw